DownMix Node and to_decibels augmentations #32

SundarRajan28 · 2024-03-13T15:08:42Z

No description provided.

fiona-gladwin

Please Address review comments

amd_openvx_extensions/amd_rpp/include/internal_publishKernels.h

amd_openvx_extensions/amd_rpp/include/vx_ext_rpp.h

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

amd_openvx_extensions/amd_rpp/include/kernels_rpp.h

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp

amd_openvx_extensions/amd_rpp/include/kernels_rpp.h

fiona-gladwin · 2024-03-25T12:59:05Z

amd_openvx_extensions/amd_rpp/include/vx_ext_rpp.h

+	 * \param[in] pSrcDims The input tensor of batch size in <tt>unsigned int<tt> containing the roi values for the input.
+	 * \param [out] pDst The output tensor in <tt>\ref VX_TYPE_FLOAT32</tt> format data.
+	 * \param[in] pDstDims The input tensor of batch size in <tt>unsigned int<tt> containing the roi values for the output. 
+	 * \param[in] cutOffDB The input scalar in <tt>\ref VX_TYPE_FLOAT32</tt> format containing  minimum or cut-off ratio in dB


Is it dims or ROI, please change name accordingly

For both srcDims and dstDims

Also is it of xywh or ltrb format? For audio

fiona-gladwin · 2024-03-25T12:59:20Z

amd_openvx_extensions/amd_rpp/include/vx_ext_rpp.h

+	 * \param[in] pSrcDims The input tensor of batch size in <tt>unsigned int<tt> containing the roi values for the input.
+	 * \param [out] pDst The output tensor in <tt>\ref VX_TYPE_FLOAT32</tt> format data.
+	 * \param[in] pDstDims The input tensor of batch size in <tt>unsigned int<tt> containing the roi values for the output. 
+	 * \param[in] cutOffDB The input scalar in <tt>\ref VX_TYPE_FLOAT32</tt> format containing  minimum or cut-off ratio in dB


Change the supported data types

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

fiona-gladwin · 2024-03-25T13:02:52Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+    // Check for input parameters
+    size_t num_tensor_dims;
+    STATUS_ERROR_CHECK(vxQueryTensor((vx_tensor)parameters[0], VX_TENSOR_NUMBER_OF_DIMS, &num_tensor_dims, sizeof(num_tensor_dims)));
+    if (num_tensor_dims < 3) return ERRMSG(VX_ERROR_INVALID_DIMENSION, "validate: Downmix: tensor: #0 dimensions=%lu (must be greater than or equal to 3)\n", num_tensor_dims);


Should the dims be greater than 3? Modify comments accordingly

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

fiona-gladwin · 2024-03-25T13:06:14Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+}
+
+//! \brief The kernel target support callback.
+// TODO::currently the node is setting the same affinity as context. This needs to change when we have hubrid modes in the same graph


Change the comment as hybrid
Please check this in Spectrogram and Pre-Emphasis filter PR as well @swetha097 Please note

fiona-gladwin · 2024-03-25T13:06:53Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+    else
+        supported_target_affinity = AGO_TARGET_AFFINITY_CPU;
+
+    // hardcode the affinity to  CPU for OpenCL backend to avoid VerifyGraph failure since there is no codegen callback for amd_rpp nodes


Is this comment applicable here, Please check this
@swetha097 Please check in other PR's too

amd_openvx_extensions/amd_rpp/source/tensor/Spectrogram.cpp

amd_openvx_extensions/amd_rpp/source/tensor/ToDecibels.cpp

fiona-gladwin · 2024-03-26T12:43:51Z

amd_openvx_extensions/amd_rpp/source/tensor/ToDecibels.cpp

+    }
+
+    return status;
+}


Add new line at EOF

@SundarRajan28 Please address this

…audio/pr6

sampath1117

Please address review comments

Also Rajy is suggesting to use uint32_t for unsigned and int32_t for int where it is used in MIVisionX for new PR's
Please do that change also in this PR for new functions added

sampath1117 · 2024-05-14T05:07:49Z

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp

@@ -2597,6 +2632,27 @@ RpptDataType getRpptDataType(vx_enum vxDataType) {
    }
 }

+RpptLayout getRpptLayout(vxTensorLayout layout) {


Rajy is suggesting to have this a map, instead of switch case
ROCm#1320 (comment)

Please remove this function and add a constant map here, and use this map in openvx extensions

sampath1117 · 2024-05-14T05:09:39Z

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp

@@ -2663,6 +2719,7 @@ void fillAudioDescriptionPtrFromDims(RpptDescPtr &descPtr, size_t *maxTensorDims
    descPtr->strides.wStride = descPtr->c;
    descPtr->strides.cStride = 1;
    descPtr->numDims = 4;
+    descPtr->layout = getRpptLayout(layout);


Use map here for the layout

sampath1117 · 2024-05-14T05:28:32Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+        STATUS_ERROR_CHECK(vxQueryTensor((vx_tensor)parameters[2], VX_TENSOR_BUFFER_HOST, &roi_tensor_ptr_src, sizeof(roi_tensor_ptr_src)));
+    }
+    RpptROI *src_roi = reinterpret_cast<RpptROI *>(roi_tensor_ptr_src);
+    for (int n = 0; n < data->inputTensorDims[0]; n++) {


Restructure the loop as below so that we have multiplication as part of loop counter

for (int n = 0, k = 0; n < data->inputTensorDims[0]; n++, k += 2) { data->psrcRoi[k] = src_roi[n].xywhROI.roiWidth; data->psrcRoi[k + 1] = src_roi[n].xywhROI.roiHeight; }

sampath1117 · 2024-05-14T05:31:56Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+    Rpp32u deviceType;
+    RppPtr_t pSrc;
+    RppPtr_t pDst;
+    vx_int32 *psrcRoi;


Please change psrcRoi to pSrcRoi

sampath1117 · 2024-05-14T05:34:57Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+#endif
+    } else if (data->deviceType == AGO_TARGET_AFFINITY_CPU) {
+        refreshDownmix(node, parameters, num, data);
+        rpp_status = rppt_down_mixing_host((float *)data->pSrc, data->pSrcDesc, (float *)data->pDst, data->pDstDesc, (Rpp32s *)data->psrcRoi, false, data->handle->rppHandle);


Please remove this casting to (float *) since it is not needed

sampath1117 · 2024-05-14T05:36:50Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+
+static vx_status VX_CALLBACK initializeDownmix(vx_node node, const vx_reference *parameters, vx_uint32 num) {
+    DownmixLocalData *data = new DownmixLocalData;
+    if (data) {


Since we are allocating the memory anyway at L106 and it is a simple structure
why do we need to check if (data) and return vx_FAILURE if not?

sampath1117 · 2024-05-14T05:38:20Z

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp

+        fillAudioDescriptionPtrFromDims(data->pDstDesc, data->outputTensorDims);
+
+        data->psrcRoi = new vx_int32[data->pSrcDesc->n * 2];
+


Remove one blank line
either at L130/L132

* Bump rocm-docs-core[api_reference] from 0.34.0 to 0.34.2 in /docs/sphinx (ROCm#1286) Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.34.0 to 0.34.2. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v0.34.0...v0.34.2) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cryptography from 42.0.0 to 42.0.2 in /docs/sphinx (ROCm#1289) Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.2. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@42.0.0...42.0.2) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add PreEmphasis filter support * Fix ROI - change from xy to width & height * Adding openvx changes for downmix node * Audio Augmentations 1 PR - NSR and Spectrogram * Revert "Adding openvx changes for downmix node" This reverts commit d53f81d. * PR comments resolution in the PreEmphais Filter * Minor Changes * Change the borderType enum to int32 from uint32 dtype * Fix validation of preemphasis * Remove the memcopy of the src and dest rois as it can be handled in the rocAL - since the src and dst rois remain same * Formatting change - minor * Remove NSR * Minor formatting changes * Minor fix * Minor update - remove the 2nd instance of preemphasis filter * Enum dtype - change from uint to int * Remove roi_tensor_ptr_dst as its unused after latest changes * Remove the dst_roi arg from vxExtRppPreemphasisFilter call as its unused * Add MFB to MIVisisonX * Revert "Add MFB to MIVisisonX" This reverts commit dc4200b. * Resolve the PR comments * Change the dims[0] and dims[1] positioning for Spectrogram and AudioFillDescPointers * Change function name to camelCase * Revert "Change the dims[0] and dims[1] positioning for Spectrogram and AudioFillDescPointers" This reverts commit 886d6af. * Fix Spectrogram * Docs - update TOC for API Ref (ROCm#1327) * Bump rocm-docs-core[api_reference] from 0.38.0 to 0.38.1 in /docs/sphinx (ROCm#1328) Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.38.0 to 0.38.1. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v0.38.0...v0.38.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update CHANGELOG.md * Update CHANGELOG.md * Documents - Bump idna from 3.4 to 3.7 in /docs/sphinx (ROCm#1330) Bumps [idna](https://github.com/kjd/idna) from 3.4 to 3.7. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst) - [Commits](kjd/idna@v3.4...v3.7) --- updated-dependencies: - dependency-name: idna dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update changelog * Resolve minor PR comments * Remove comments * Docs - Bump tqdm from 4.65.0 to 4.66.3 in /docs/sphinx (ROCm#1339) Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.65.0 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](tqdm/tqdm@v4.65.0...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump jinja2 from 3.1.3 to 3.1.4 in /docs/sphinx (ROCm#1340) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Find Half - Fix (ROCm#1341) * MIVisionX Setup - Updates (ROCm#1343) * SWDEV-459739 - Remove the package obsolete setting (ROCm#1345) The package was obsoleting itself and was causing upgrade issues. Removed the same. * Fix the layout issue with spec * Add layouts for Audio in vxTensorLayout Remove spectrogram layout param and pass layout in descriptor * Check the validity of pointers * Audio PR - Augmentation support [ Spectrogram ] (ROCm#1319) * Bump rocm-docs-core[api_reference] from 0.34.0 to 0.34.2 in /docs/sphinx (ROCm#1286) Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.34.0 to 0.34.2. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v0.34.0...v0.34.2) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cryptography from 42.0.0 to 42.0.2 in /docs/sphinx (ROCm#1289) Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.2. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@42.0.0...42.0.2) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add PreEmphasis filter support * Fix ROI - change from xy to width & height * Adding openvx changes for downmix node * Audio Augmentations 1 PR - NSR and Spectrogram * Revert "Adding openvx changes for downmix node" This reverts commit d53f81d. * PR comments resolution in the PreEmphais Filter * Minor Changes * Change the borderType enum to int32 from uint32 dtype * Fix validation of preemphasis * Remove the memcopy of the src and dest rois as it can be handled in the rocAL - since the src and dst rois remain same * Formatting change - minor * Remove NSR * Minor formatting changes * Minor fix * Minor update - remove the 2nd instance of preemphasis filter * Enum dtype - change from uint to int * Remove roi_tensor_ptr_dst as its unused after latest changes * Remove the dst_roi arg from vxExtRppPreemphasisFilter call as its unused * Add MFB to MIVisisonX * Revert "Add MFB to MIVisisonX" This reverts commit dc4200b. * Resolve the PR comments * Change the dims[0] and dims[1] positioning for Spectrogram and AudioFillDescPointers * Change function name to camelCase * Revert "Change the dims[0] and dims[1] positioning for Spectrogram and AudioFillDescPointers" This reverts commit 886d6af. * Fix Spectrogram * Docs - update TOC for API Ref (ROCm#1327) * Bump rocm-docs-core[api_reference] from 0.38.0 to 0.38.1 in /docs/sphinx (ROCm#1328) Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.38.0 to 0.38.1. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v0.38.0...v0.38.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update CHANGELOG.md * Update CHANGELOG.md * Documents - Bump idna from 3.4 to 3.7 in /docs/sphinx (ROCm#1330) Bumps [idna](https://github.com/kjd/idna) from 3.4 to 3.7. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst) - [Commits](kjd/idna@v3.4...v3.7) --- updated-dependencies: - dependency-name: idna dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update changelog * Resolve minor PR comments * Remove comments * Fix the layout issue with spec * Check the validity of pointers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: root <root@ixt-sjc2-54.local.lan> Co-authored-by: Swetha B S <swetha@mutlicorewareinc.com> Co-authored-by: SundarRajan28 <sundarrajan@multicorewareinc.com> Co-authored-by: Swetha B S <swetha@multiocrewareinc.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> * Introduce API to obtain RPP layout * Add comments * Use RPP_AUDIO flag to disable RPP audio calls * Add Audio flag for PreEmphasis filter --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: root <root@ixt-sjc2-54.local.lan> Co-authored-by: Swetha B S <swetha@mutlicorewareinc.com> Co-authored-by: Swetha B S <swetha@multicorewareinc.com> Co-authored-by: SundarRajan28 <sundarrajan@multicorewareinc.com> Co-authored-by: Swetha B S <swetha@multiocrewareinc.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: swetha097 <59434434+swetha097@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: raramakr <91213141+raramakr@users.noreply.github.com> Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

SundarRajan28 requested review from fiona-gladwin and snehaa8 March 13, 2024 15:08

fiona-gladwin requested changes Mar 14, 2024

View reviewed changes

snehaa8 reviewed Mar 14, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/include/kernels_rpp.h Outdated Show resolved Hide resolved

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp Outdated Show resolved Hide resolved

Merging swbs_m2/audio/pr5 into swbs_m3/audio/pr6

ba6ff14

SundarRajan28 changed the base branch from swbs_m1/audio/pr3 to swbs_m2/audio/pr5 March 15, 2024 14:18

Fixing build issues

e94c53f

swetha097 added the audio pr label Mar 18, 2024

SundarRajan28 added 8 commits March 22, 2024 13:33

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

4495d5c

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

247cf70

Add openvx extensions for to_decibels augmentations

1a51fee

Merge branch 'swbs_m1/audio/pr3' into swbs_m3/audio/pr6

e8ff20e

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

a649fba

Fixing issues with src ROI

01aba8a

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

a25b645

Resolving review comments

68a5d7e

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/include/kernels_rpp.h Outdated Show resolved Hide resolved

SundarRajan28 changed the title ~~DownMix Node Augmentation~~ DownMix Node and to_decibels augmentations Mar 25, 2024

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp Outdated Show resolved Hide resolved

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp Show resolved Hide resolved

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp Outdated Show resolved Hide resolved

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Downmix.cpp Outdated Show resolved Hide resolved

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Spectrogram.cpp Outdated Show resolved Hide resolved

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/ToDecibels.cpp Outdated Show resolved Hide resolved

fiona-gladwin reviewed Mar 25, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/ToDecibels.cpp Outdated Show resolved Hide resolved

SundarRajan28 added 2 commits March 25, 2024 17:47

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

ce4778f

Resolving review comments

070bd82

fiona-gladwin reviewed Mar 26, 2024

View reviewed changes

SundarRajan28 added 2 commits March 26, 2024 12:44

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

658504f

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

a2c1063

swetha097 assigned SundarRajan28 Apr 3, 2024

SundarRajan28 and others added 8 commits April 16, 2024 08:34

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

b08b602

Update changelog

3be53bf

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

c69afd8

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

58d8c0d

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

4121a9c

Merge remote-tracking branch 'upstream/develop' into swbs_m3/audio/pr6

d7db0cb

Resolving review comments

81c5533

Merge remote-tracking branch 'swbs_m2/audio/pr5_layout' into swbs_m3/…

209b83a

…audio/pr6

sampath1117 reviewed May 14, 2024

View reviewed changes

This was referenced May 14, 2024

Audio PR7 - Audio augmentations 2 (MFBB and Normalize) #33

Open

Audio PR 8 - Resample + Operator Overloading Nodes #34

Open

SundarRajan28 and others added 13 commits May 15, 2024 03:46

Resolving review comments

e0883dd

Minor changes

a849125

Removing if blocks for CPU device checks

36fdc89

Merge remote-tracking branch 'upstream/develop' into swbs_m3/audio/pr6

99eeb10

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

fefc759

Add RPP_AUDIO flag for RPP audio API

ff3c50f

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

3f8d1c8

Merge remote-tracking branch 'upstream/develop' into swbs_m3/audio/pr6

f1cb901

Merge branch 'develop' into swbs_m3/audio/pr6

f601ad9

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

b1c7694

Merge remote-tracking branch 'upstream/develop' into swbs_m3/audio/pr6

f4dd4e3

Rename map variable

832d9ef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DownMix Node and to_decibels augmentations #32

DownMix Node and to_decibels augmentations #32

SundarRajan28 commented Mar 13, 2024

fiona-gladwin left a comment

fiona-gladwin Mar 25, 2024 •

edited

Loading

fiona-gladwin Mar 25, 2024

fiona-gladwin Mar 25, 2024

fiona-gladwin Mar 25, 2024

fiona-gladwin Mar 25, 2024

fiona-gladwin Mar 25, 2024

fiona-gladwin Mar 26, 2024

fiona-gladwin Mar 27, 2024

sampath1117 left a comment •

edited

Loading

sampath1117 May 14, 2024

sampath1117 May 14, 2024

sampath1117 May 14, 2024

sampath1117 May 14, 2024

sampath1117 May 14, 2024

sampath1117 May 14, 2024

sampath1117 May 14, 2024

		fillAudioDescriptionPtrFromDims(data->pDstDesc, data->outputTensorDims);

		data->psrcRoi = new vx_int32[data->pSrcDesc->n * 2];

DownMix Node and to_decibels augmentations #32

Are you sure you want to change the base?

DownMix Node and to_decibels augmentations #32

Conversation

SundarRajan28 commented Mar 13, 2024

fiona-gladwin left a comment

Choose a reason for hiding this comment

fiona-gladwin Mar 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sampath1117 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fiona-gladwin Mar 25, 2024 •

edited

Loading

sampath1117 left a comment •

edited

Loading