Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DownMix Node and to_decibels augmentations #32
base: swbs_m2/audio/pr5
Are you sure you want to change the base?
DownMix Node and to_decibels augmentations #32
Changes from 24 commits
ba6ff14
e94c53f
4495d5c
247cf70
1a51fee
e8ff20e
a649fba
01aba8a
a25b645
68a5d7e
ebe8933
a446bff
ce4778f
070bd82
658504f
a2c1063
b08b602
3be53bf
c69afd8
58d8c0d
4121a9c
d7db0cb
81c5533
209b83a
e0883dd
a849125
36fdc89
99eeb10
fefc759
ff3c50f
3f8d1c8
f1cb901
f601ad9
0df3adb
b1c7694
f4dd4e3
832d9ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it dims or ROI, please change name accordingly
For both srcDims and dstDims
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also is it of xywh or ltrb format? For audio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the supported data types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change psrcRoi to pSrcRoi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restructure the loop as below so that we have multiplication as part of loop counter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the dims be greater than 3? Modify comments accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this casting to (float *) since it is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are allocating the memory anyway at L106 and it is a simple structure
why do we need to check if (data) and return vx_FAILURE if not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove one blank line
either at L130/L132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment applicable here, Please check this
@swetha097 Please check in other PR's too