Add support for unix "abstract namespace" addresses #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 94.56% 94.53% -0.03%
==========================================
Files 62 62
Lines 4119 4119
==========================================
- Hits 3895 3894 -1
- Misses 224 225 +1 ☔ View full report in Codecov by Sentry. |
|
the linux error seems spurious? |
swhitty
approved these changes
Jun 16, 2025
swhitty
reviewed
Jun 16, 2025
| raw.initializeMemory(as: CChar.self, repeating: 0) | ||
| } | ||
|
|
||
| let nameBytes = Array(name.utf8.prefix(107)) |
There was a problem hiding this comment.
I'm wondering if we should add a constant for this max as its actually used in a couple of other places (macOS: 104, linux: 108)
extension Socket {
static let sunPathMax = MemoryLayout.size(ofValue: sockaddr_un().sun_path)
}
Yeah I think a flakey test I need to investigate, passes on retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.