Make FlyingFox pass tests without warnings/crashes in Xcode 14 beta 4 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swhitty
reviewed
Aug 1, 2022
|
Thanks @sergiocampama much appreciated. I am more than happy to support Swift 5.7 as long as the changes are backwards compatible with Swift 5.5. |
sergiocampama
commented
Aug 1, 2022
sergiocampama
commented
Aug 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 43 43
Lines 2123 2124 +1
=======================================
+ Hits 2115 2116 +1
Misses 8 8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing FlyingFox on Xcode 14 (planning on offering/contributing some new features, love this project :) ) and found that the tests crashed on some unsafePointer stuff, and traced it to this PR: swiftlang/swift#42002
Most likely the usage of the new inout APIs will be considered wrong, so wanted to send in this to help in the mean time.
Feel free to reject on the basis that Xcode 14 is beta and that you only support mainline builds of Xcode, but I think the unsafePointer changes are safe to include, on the basis that it enforces the usage of the UnsafePointer API and not the inout version.
The convenience removal was also a warning in Xcode 14 beta 4 (at least), unclear if that will be an issue in previous versions of Xcode (personal computer only has the latest edge macOS and Xcode versions :p )