Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert asserts to exception in java [DEVINFRA-1035] #1260

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

adrian-kong
Copy link
Contributor

handle these assertion errors as SBPBinaryException rather than asserts

@adrian-kong adrian-kong requested a review from a team as a code owner December 7, 2022 02:11
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should turn off code duplication as a SonarCloud metric for libsbp

@adrian-kong adrian-kong merged commit d23e37f into master Dec 7, 2022
@adrian-kong adrian-kong deleted the adrian/java-exception branch December 7, 2022 03:02
@adrian-kong
Copy link
Contributor Author

agree^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants