Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto submodule update: libsbp - Make the BaseTime inner public (#1332) #558

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Auto submodule update: libsbp - Make the BaseTime inner public (#1332) #558

merged 1 commit into from
Jun 7, 2023

Conversation

swiftnav-svc-jenkins
Copy link
Contributor

@swiftnav-svc-jenkins swiftnav-svc-jenkins commented May 26, 2023 •
edited by jira bot
Loading

Automated PR by Jenkins. If CI has passed successfully, merge away!

cmake f4d30717 -> 12b7f037

libsbp 3621e92f -> 25e15c6c

WARNING the following submodules are not consistent

cmake

  • cmake : 12b7f037e7cc721a9a36c7342ba2ca2b0cafc01e
  • libsbp/cmake : 12b7f037e7cc721a9a36c7342ba2ca2b0cafc01e
  • libswiftnav/cmake : b8d744bd40f8254ec5543c80658e70350eff2863

This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/14266/.

@swiftnav-svc-jenkins
libsbp - Make the BaseTime inner public
2b1edc3 
# Description

@swift-nav/devinfra

This PR converts the BaseTime tuple struct into an enum with one variant
and makes it non_exhaustive. This enables users to access the time
inside and makes it similar to how RoverTime can be used.
 
# API compatibility

Does this change introduce a API compatibility risk?

In general you cannot convert an struct to an enum without it being a
breaking change. However, because the enum was a tuple struct with
private fields it's constructor was also private, and you cannot create
it even with the dot syntax.
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=0369878bb675f5734febf4ad1eebf327

So that means that the chances of this being a breaking change is very
small and I feel comfortable marking this as a minor change.

If the above is "Yes", please detail the compatibility (or migration)
plan:

N/A

# JIRA Reference

would resolve: swift-nav/libsbp#1331

---------

Co-authored-by: Jason Mobarak <jason@swift-nav.com>

Triggered-By:	libsbp	25e15c6c7d63c6cdd73cf38f6d6bffd2fe80f84e
Upstream-PR:	http://github.com/swift-nav/libsbp/pull/1332
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@silverjam silverjam merged commit fb3a29f into master Jun 7, 2023
@silverjam silverjam deleted the auto-submodule-pointer-update/id-25e15c6c7d branch June 7, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcrumley pcrumley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swiftnav-svc-jenkins @silverjam @pcrumley