Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off duplicate detection in SonarCloud for test targets [SEN-798] #150

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

reimerix
Copy link
Contributor

@reimerix reimerix commented Mar 27, 2023

Turning off code duplication warnings for test targets. Tested in Starling here: https://github.com/swift-nav/starling/pull/7760

This has been getting into our way a lot, since we want to make most tests DAMP rather than DRY.

@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@silverjam
Copy link
Contributor

@isaactorz Do we need to log a Jira ticket to implement this feature in Bazel?

@jungleraptor
Copy link
Contributor

@isaactorz Do we need to log a Jira ticket to implement this feature in Bazel?

I'll add it to the ticket that tracks bazel integration with sonarcloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants