add MsgAcknowledge #1263
add MsgAcknowledge #1263
Conversation
spec/yaml/swiftnav/sbp/skylark.yaml
Outdated
| fields: | ||
| - request_counter: | ||
| type: u8 | ||
| desc: Echo of the request counter field from the corresponding CRA message, or 255 if no request counter was provided. |
There was a problem hiding this comment.
To me a "counter" implies a sequence that starts at zero and I'm not sure that that's important for this message, I've proposed to System Design that this be reword/recast as a "request ID" so that we don't have the implied behavior of a counter-- do you have thoughts on this?
There was a problem hiding this comment.
I agree, especially considering we just added stream_counter and on_demand_counter which behavior exactly as you describe, I'll see about changing the documentation
spec/yaml/swiftnav/sbp/skylark.yaml
Outdated
| fields: | ||
| - 0-7: | ||
| desc: Response code | ||
| values: | ||
| - 0: Ok | ||
| - 1: Out of coverage | ||
| - 2: Forbidden | ||
| - 3: Invalid request | ||
| - 4: Invalid area id |
There was a problem hiding this comment.
this generates "masking" code:
#define SBP_ACKNOWLEDGE_RESPONSE_CODE_MASK (0xffu)
#define SBP_ACKNOWLEDGE_RESPONSE_CODE_SHIFT (0u)
#define SBP_ACKNOWLEDGE_RESPONSE_CODE_GET(flags) \
((u8)((u8)((flags) >> SBP_ACKNOWLEDGE_RESPONSE_CODE_SHIFT) & \
SBP_ACKNOWLEDGE_RESPONSE_CODE_MASK))
#define SBP_ACKNOWLEDGE_RESPONSE_CODE_SET(flags, val) \
do { \
(flags) = (u8)((flags & (~(SBP_ACKNOWLEDGE_RESPONSE_CODE_MASK \
<< SBP_ACKNOWLEDGE_RESPONSE_CODE_SHIFT))) | \
(((val) & (SBP_ACKNOWLEDGE_RESPONSE_CODE_MASK)) \
<< (SBP_ACKNOWLEDGE_RESPONSE_CODE_SHIFT))); \
} while (0)Which is strange as this variable doesn't represent a bit mask field. Is there any type that represents enumerator types rather bit fields?
With the current setup, we are going to be limited to only being able to add 3 more error codes in the future rather than 200 more possible values.
There was a problem hiding this comment.
Hmm I thought what I have should work, should be the same as
libsbp/spec/yaml/swiftnav/sbp/gnss.yaml
Line 33 in 0e72dc0
There was a problem hiding this comment.
Looks like that generates similar code. I guess if you have
fields:
- 0-7: ... # or 0 to whatever size int it iswe could probably just skip generating the mask/shifting bit and just generate the constants like -
libsbp/c/include/libsbp/gnss_macros.h
Line 32 in 0e72dc0
spec/yaml/swiftnav/sbp/skylark.yaml
Outdated
| type: u16 | ||
| desc: > | ||
| Contains the message group(s) that will be sent in response from the corresponding CRA correction mask. | ||
| An echo of the correction mask field from the corresponding CRA message. |
There was a problem hiding this comment.
this can be a bit mask field.
| Name | Bit | Description |
|---|---|---|
| Key | 0 | Public Signing Key |
| Low-Rate Messages | 1 | ITRF, UTC and APC Messages |
| Ephemeris | 2 | Ephemeris data |
| Satellite Clock | 3 | Clocks |
| Satellite Orbit | 4 | Orbit |
| Satellite code bias | 5 | Code Biases |
| Satellite phase bias | 6 | Phase Biases |
| Atmospherics | 7 | Tile Definition, STEC and Grid data |
| Integrity | 8 | Bounds, Degradation, and Flags |
| Reserved | 9-15 |
There was a problem hiding this comment.
Ahh right thanks, added it
| { | ||
| "copyright": [ |
There was a problem hiding this comment.
I think someone forgot to run all the code gen at some point, and missed some for this message -
libsbp/spec/yaml/swiftnav/sbp/navigation.yaml
Line 2559 in 19bd162
Description
@swift-nav/devinfra
Implements message defined here - https://swift-nav.atlassian.net/wiki/spaces/ENG/pages/2385609303/Acknowledge+Message+-+Requirements+Doc#2.-Interface-Requirements
None of the existing packages seemed right so I created a
skylarkpackage, happy to change that around if anyone has a better ideaJIRA Reference
https://swift-nav.atlassian.net/browse/SKYL-65