-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add friendly_name method [DEVINFRA-1045] #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To statisfy SonarCloud let's add a simple unit test to Java that asserts that the friend name for each message is not empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about possibly adding fn friendly_name(&self) -> &'static str
to SbpMessage
so you can directly fetch the friendly name, but that can be done later so LGTM!
Add friendly_name method which trims out keywords