-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Makefile with bazel wrappers [BUILD-360] #1289
Conversation
@silverjam @isaactorz using clang-format with bazel doesn't work for me here:
Is it okay for me to update the libsbp's config? |
I don't think so, that will break formatting in CI I'm pretty sure. Several months ago now we went and updated all of the codebase to using clang-format-14 and clang-tidy-14 but we overlooked this repo because formatting is set up a little differently than the rest. We also need to update the formatter in the base image to get it going in CI. Let's punt on enabling formatting w/ bazel in this project for right now. |
I removed clang-format related configuration to avoid any confusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
@swift-nav/devinfra
Adding a Makefile into the
c
directory for commonly used bazel commands to make it easier for developers to start using bazel.Added targets:
I'm using aspects to run clang-format and clang-tidy on each file. You can see the setup in .bazelrc
I'm loading .clang-format configuration in .bazelrc
API compatibility
Doesn't break anything, it's just a new Makefile
JIRA Reference
https://swift-nav.atlassian.net/browse/BUILD-360