Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass all features to docs.rs build #1333

Merged
merged 4 commits into from
May 26, 2023
Merged

Conversation

pcrumley
Copy link
Contributor

Description

@swift-nav/devinfra

This ensures that --all-features is passed to cargo doc when building for docs.rs : see description here: https://docs.rs/about/metadata

API compatibility

Does this change introduce a API compatibility risk?

No, purely a cargo doc build change

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

N/A

JIRA Reference

N/A

@pcrumley pcrumley requested a review from a team as a code owner May 25, 2023 22:36
@pcrumley pcrumley requested a review from notoriaga May 25, 2023 22:36
@pcrumley
Copy link
Contributor Author

i don't know why the gen files don't line up. running make gen-rust on my local machine fails due to tox errors

@silverjam
Copy link
Contributor

i don't know why the gen files don't line up. running make gen-rust on my local machine fails due to tox errors

You have to use the docker container to run the generator at the moment

@silverjam silverjam enabled auto-merge (squash) May 26, 2023 03:21
@silverjam silverjam merged commit 21f317a into master May 26, 2023
@silverjam silverjam deleted the patrick/pass-all-features-to-docs branch May 26, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants