SwiftAsync: use runtime-provided flag for extended frame if back-deploying #3191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci please test |
Author
|
@llvm-ci please test |
Author
|
@swift-ci please test |
…oying When back-deploying Swift async code we can't always toggle the flag showing an extended frame is present because it will confuse unwinders on systems released before this feature. So in cases where the code might run there, we `or` in a mask provided by the runtime (as an absolute symbol) telling us whether the unwinders can cope. When deploying only for newer OSs, we can still hard-code the bit-set for greater efficiency. rdar://79357449
Since Xcode 13, ld64 requires linking libSystem for all the executable. Fix the tests that needs to run ld64 by linking libSystem from sysroot. rdar://77332728 Reviewed By: fhahn Differential Revision: https://reviews.llvm.org/D104332
TNorthover
force-pushed
the
eng/PR-79357449-2
branch
from
5758def to
ac8d1da
Compare
Author
|
@swift-ci please test |
aschwaighofer
pushed a commit
that referenced
this pull request
Sep 10, 2021
SwiftAsync: use runtime-provided flag for extended frame if back-deploying
aschwaighofer
pushed a commit
to aschwaighofer/llvm-project
that referenced
this pull request
Sep 10, 2021
SwiftAsync: use runtime-provided flag for extended frame if back-deploying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When back-deploying Swift async code we can't always toggle the flag showing an
extended frame is present because it will confuse unwinders on systems released
before this feature. So in cases where the code might run there, we
orin amask provided by the runtime (as an absolute symbol) telling us whether the
unwinders can cope.
When deploying only for newer OSs, we can still hard-code the bit-set for
greater efficiency.