Emit warnings when Info.plist key values from different user-supplied sources conflict

[owenv]

Currently when a build setting corresponding to an Info.plist key is set, and the same Info.plist key is set in the INFOPLIST_FILE, the build system will silently overwrite one with the other.

Since the behavior of which wins might be surprising or non-obvious to users, we should emit a warning when the two sides are in conflict, so users can ensure the intended effect of the merging process.

For scalar values, this is straightforward, and for arrays and dictionaries, we might choose an append/merge behavior depending on the key, and also emit warnings for conflicting keys hierarchically throughout nested dictionaries.

[theSalted]

Hi @owenv, I am interested in fixing this. Can you give me some pointers, mainly which framework targets handles Info.plist. Thanks!

[owenv]

@theSalted sure! I recommend starting by taking a look at InfoPlistProcessorTaskAction.swift - this contains the implementation of the task which processes hand-authored Info.plist content, build settings, etc. to produce the complete Info.plist file which is embedded in the product. The defaultInfoPlistContent method in particular is a good place to start exploring how the various sources of info get merged.