Emit warnings when conflicts detected in Info.plist key values #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSalted
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
owenv
reviewed
Mar 29, 2025
|
@swift-ci test |
|
@theSalted I think the bot used to update your fork overwrote the changes in this PR and It was auto-closed since it now matches |
Sorry about that! I am gonna disable it for this repo. I will start a new PR once I am done with the test-case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a building setting is set from an info.plist key, if the same key is set from another source. The previous one will be silently overwritten. This pull request added
detectConflict()to detects if two PropertyListItem values are in conflict and emits an appropriate warning message if they are.Resolves #5