[6.0.x] URL.deletingLastPathComponent() should append .. in special cases #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Oh, the test expects the behavior from the |
|
@swift-ci please test |
|
Tests pass now that #1013 is merged |
parkera
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Corrects
URL.deletingLastPathComponent()behavior to append..in special cases, such as when the relative path is empty or ends in a..segment. This makes.deletingLastPathComponent()semantically accurate when resolving against a base URL.Scope: Only impacts
URL.deletingLastPathComponent()in special cases of relative paths.Original PR: #989
Risk: Low - Small change to fix behavior for these edge cases.
Testing: Added comprehensive unit test, swift-ci, stable in
mainReviewer: @itingliu
Resolves #922 for
release/6.0