Build: create static libraries explicitly with libtool. #5948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguez
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
neonichu
approved these changes
Dec 6, 2022
|
@swift-ci please smoke test |
This matches the implementation of the static linker in swift-driver, which always adds the explicit `-static`. https://github.com/apple/swift-driver/blob/caa81e560362a4e14034cd4502114d03e45ea261/Sources/SwiftDriver/Jobs/DarwinToolchain%2BLinkerSupport.swift#L95-L102
drodriguez
force-pushed
the
libtool-explicit-static
branch
from
72427ee to
b090688
Compare
|
Modify the test that checks the correct command line is used. Sorry about forgetting that. |
|
@swift-ci please smoke test |
|
Is the error in Swift Test Linux Platform related? |
|
@swift-ci smoke test Linux |
|
@swift-ci smoke test windows |
|
Every platform seems to be green. Is this good to merge? |
|
I believe so, thanks @drodriguez! |
|
should we add (or modify) a test for this? |
The existing test was modified to also expect the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always pass the
-staticparameter, instead of relying on the default oflibtool.Motivation:
This matches the implementation of the static linker in swift-driver, which always adds the explicit
-static.https://github.com/apple/swift-driver/blob/caa81e560362a4e14034cd4502114d03e45ea261/Sources/SwiftDriver/Jobs/DarwinToolchain%2BLinkerSupport.swift#L95-L102
Additionally, this improves the compatibility with LLVM's libtool, which does not (intentionally) default to static libraries (it defaults to do nothing).
Modifications:
Adds a new parameter
-staticfor every invocation oflibtoolto create static libraries in Darwin.Result:
The internal invocation of libtool always uses the
-static. No changes should be experienced, since this is the default for cctools'libtool./cc @compnerd as the author of #5720 which added the usage of
libtool