Set file-system as device-agnostic in build manifest
#7052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pusukuri
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
MaxDesiatov
approved these changes
Nov 5, 2023
|
@swift-ci test |
MaxDesiatov
requested changes
Nov 5, 2023
|
Looking into the tests. Thank you, @MaxDesiatov |
|
@swift-ci test |
MaxDesiatov
changed the title
file-system as device-agnostic in build manifest
|
@swift-ci test windows |
|
@swift-ci test windows |
MaxDesiatov
pushed a commit
that referenced
this pull request
Dec 12, 2023
sets file-system as device-agnostic in build manifest ### Motivation: This is the default mode in XCBuild, and allows incremental builds to work across reboots on APFS. It would also likely address #4651. ### Modifications: sets file-system as device-agnostic in build manifest ### Result: Restarting your system (or inode changes) doesn't invoke unnecessary builds Related to rdar://96403757.
MaxDesiatov
added a commit
that referenced
this pull request
Dec 13, 2023
Cherry-pick of #7052. ### Motivation: This is the default mode in XCBuild, and allows incremental builds to work across reboots on APFS. It would also likely address #4651. ### Modifications: Set `file-system` as `device-agnostic` in the generated build manifest ### Result: Restarting your system (or inode changes) doesn't invoke unnecessary builds Related to rdar://96403757. Co-authored-by: Kishore Pusukuri <kishoreguptaos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sets file-system as device-agnostic in build manifest
Motivation:
This is the default mode in XCBuild, and allows incremental builds to work across reboots on APFS. It would also likely address #4651.
Modifications:
sets file-system as device-agnostic in build manifest
Result:
Restarting your system (or inode changes) doesn't invoke unnecessary builds
Related to rdar://96403757.