Skip to content

[5.10] Set file-system as device-agnostic in build manifest #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Dec 12, 2023

Cherry-pick of #7052.

Motivation:

This is the default mode in XCBuild, and allows incremental builds to work across reboots on APFS. It would also likely address #4651.

Modifications:

Set file-system as device-agnostic in the generated build manifest

Result:

Restarting your system (or inode changes) doesn't invoke unnecessary builds

Related to rdar://96403757.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
sets file-system as device-agnostic in build manifest  

### Motivation:

This is the default mode in XCBuild, and allows incremental builds to
work across reboots on APFS. It would also likely address
#4651.


### Modifications:

sets file-system as device-agnostic in build manifest

### Result:

Restarting your system (or inode changes) doesn't invoke unnecessary
builds

Related to rdar://96403757.
@MaxDesiatov MaxDesiatov added bug swift 5.10 This PR targets the 5.10 branch build system Changes to interactions with build systems labels Dec 12, 2023
@MaxDesiatov MaxDesiatov self-assigned this Dec 12, 2023
@MaxDesiatov MaxDesiatov changed the title Set file-system as device-agnostic in build manifest (#7052) [5.10] Set file-system as device-agnostic in build manifest Dec 12, 2023
@MaxDesiatov MaxDesiatov requested a review from pusukuri December 12, 2023 15:17
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov merged commit 1ce90f2 into release/5.10 Dec 13, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/device-agnostic-5.10 branch December 13, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build system Changes to interactions with build systems swift 5.10 This PR targets the 5.10 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants