-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gender-neutral language #162
Conversation
@@ -2930,7 +2930,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> { | |||
|
|||
if (!IsSecondPass) { | |||
for (unsigned i = 0, e = PBD->getNumPatternEntries(); i != e; ++i) { | |||
// Type check each VarDecl in that his PatternBinding handles. | |||
// Type check each VarDecl in that their PatternBinding handles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supposed to say "Type check each VarDecl that this PatternBinding handles.".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwillmor good point. I think this is a bad PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tangentfairy - I'm not sure it's humor at all.. look here #165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shirk The user @pcbro is definitely trying to get a rise out of someone -- the account is fashioned after the character "PC Principal" in South Park, who's somewhat of a caricature of an politically correct person. This doesn't mean the PRs should be ignored, but the intent behind them is pretty clear to me.
It appears to me somebody just wants to become a contributor really bad. |
I think @cwillmor's right that the typo is different. Eliminating pointless gendered language in general is welcome though. (Comments like "get a grip", "this doesn't matter", and other silencing tactics are disrespectful and definitely aren't welcome.) |
Completely agree with you @jckarter 😄 |
Handled issue swiftlang#162 squashed multiple typo fix commits
@pcbro is just being a troll |
@AdamHess Remember Poe's law. If their contribution is helpful and aligned with our goals, who's really getting trolled? |
@jckarter this is not @pcbro first pull request to this repo. Additionally, it's NOT helpful it's a typo. @pcbro is not being helpful by pointing out typos but making uneducated fun of various programming terminology and practices see earlier pull request: #165 I cant beleive that the project maintainers even merged the request. |
Handled issue swiftlang#162 squashed multiple typo fix commits
@jckarter exactly, 👍 |
@hirad I'm well aware of it. The problem is that his pull requests are being accepted and merged into the master branch. |
I think we're done here. |
Fixes inconsiderate comment