Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gender-neutral language #162

Closed
wants to merge 1 commit into from
Closed

Use gender-neutral language #162

wants to merge 1 commit into from

Conversation

pcbro
Copy link
Contributor

@pcbro pcbro commented Dec 4, 2015

Fixes inconsiderate comment

@@ -2930,7 +2930,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {

if (!IsSecondPass) {
for (unsigned i = 0, e = PBD->getNumPatternEntries(); i != e; ++i) {
// Type check each VarDecl in that his PatternBinding handles.
// Type check each VarDecl in that their PatternBinding handles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to say "Type check each VarDecl that this PatternBinding handles.".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillmor good point. I think this is a bad PR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is hilarious but @cwillmor is right and it is just a typo. We have to appreciate @pcbro's sense of humour though 😛

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangentfairy - I'm not sure it's humor at all.. look here #165

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shirk The user @pcbro is definitely trying to get a rise out of someone -- the account is fashioned after the character "PC Principal" in South Park, who's somewhat of a caricature of an politically correct person. This doesn't mean the PRs should be ignored, but the intent behind them is pretty clear to me.

@przemekblasiak
Copy link

It appears to me somebody just wants to become a contributor really bad.

@jckarter
Copy link
Contributor

jckarter commented Dec 4, 2015

I think @cwillmor's right that the typo is different. Eliminating pointless gendered language in general is welcome though. (Comments like "get a grip", "this doesn't matter", and other silencing tactics are disrespectful and definitely aren't welcome.)

@tangentfairy-zz
Copy link

Completely agree with you @jckarter 😄

mightydeveloper added a commit to mightydeveloper/swift that referenced this pull request Dec 4, 2015
Handled issue swiftlang#162
squashed multiple typo fix commits
@AdamHess
Copy link

AdamHess commented Dec 4, 2015

@pcbro is just being a troll

@benlangmuir
Copy link
Contributor

This was fixed per @cwillmor's suggestion as part of #186.

@benlangmuir benlangmuir closed this Dec 4, 2015
@jckarter
Copy link
Contributor

jckarter commented Dec 4, 2015

@AdamHess Remember Poe's law. If their contribution is helpful and aligned with our goals, who's really getting trolled?

@AdamHess
Copy link

AdamHess commented Dec 4, 2015

@jckarter this is not @pcbro first pull request to this repo. Additionally, it's NOT helpful it's a typo. @pcbro is not being helpful by pointing out typos but making uneducated fun of various programming terminology and practices see earlier pull request: #165 I cant beleive that the project maintainers even merged the request.

@AdamHess
Copy link

AdamHess commented Dec 4, 2015

God I just realized @jckarter is working in cahoots with @pcbro ... so its basically apple trolling the dev community. Good job.

@hirad
Copy link

hirad commented Dec 4, 2015

@AdamHess @pcbro's entire account is referencing a South Park parody of SJWs. I think you're right. I don't understand why he's taken seriously.

lowell pushed a commit to lowell/swift that referenced this pull request Dec 4, 2015
Handled issue swiftlang#162
squashed multiple typo fix commits
@steveklabnik
Copy link
Contributor

@jckarter exactly, 👍

@AdamHess
Copy link

AdamHess commented Dec 5, 2015

@hirad I'm well aware of it. The problem is that his pull requests are being accepted and merged into the master branch.

@jckarter
Copy link
Contributor

jckarter commented Dec 5, 2015

I think we're done here.

@swiftlang swiftlang locked and limited conversation to collaborators Dec 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.