Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gender-neutral language #162

Closed
wants to merge 1 commit into from
Closed

Use gender-neutral language #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Sema/TypeCheckDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2930,7 +2930,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {

if (!IsSecondPass) {
for (unsigned i = 0, e = PBD->getNumPatternEntries(); i != e; ++i) {
// Type check each VarDecl in that his PatternBinding handles.
// Type check each VarDecl in that their PatternBinding handles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to say "Type check each VarDecl that this PatternBinding handles.".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillmor good point. I think this is a bad PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is hilarious but @cwillmor is right and it is just a typo. We have to appreciate @pcbro's sense of humour though 😛

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangentfairy - I'm not sure it's humor at all.. look here #165

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shirk The user @pcbro is definitely trying to get a rise out of someone -- the account is fashioned after the character "PC Principal" in South Park, who's somewhat of a caricature of an politically correct person. This doesn't mean the PRs should be ignored, but the intent behind them is pretty clear to me.

visitBoundVars(PBD->getPattern(i));

// If we have a type but no initializer, check whether the type is
Expand Down