Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoDiff upstream] Clean up parsing and printing. #28377

Merged
merged 1 commit into from
Nov 20, 2019
Merged

[AutoDiff upstream] Clean up parsing and printing. #28377

merged 1 commit into from
Nov 20, 2019

Conversation

dan-zheng
Copy link
Contributor

  • Use general Parser::isIdentifier(Token, StringRef) function.
    • Remove specialized isWRTIdentifier, isJVPIdentifier, isVJPIdentifier
      functions from Parser.
  • Clarify doc comments and parameter nullability for attribute printing code:
    getDifferentiationParametersClauseString.
  • Minor formatting and naming updates.

Addresses feedback from #28321.
tensorflow branch mirror: #28376.

@dan-zheng
[AutoDiff upstream] Clean up parsing and printing.
684f127 
- Use general `Parser::isIdentifier(Token, StringRef)` function.
  - Remove specialized `isWRTIdentifier`, `isJVPIdentifier`, `isVJPIdentifier`
    functions from `Parser`.
- Clarify doc comments and parameter nullability for attribute printing code:
  `getDifferentiationParametersClauseString`.
- Minor formatting and naming updates.
@dan-zheng dan-zheng mentioned this pull request Nov 20, 2019
Merged
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

lattner
lattner approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@lattner lattner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the null safety of this code!

@dan-zheng dan-zheng merged commit baed359 into swiftlang:master Nov 20, 2019
@dan-zheng dan-zheng deleted the autodiff-upstream-cleanup branch November 20, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@lattner lattner lattner approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

@bgogul bgogul Awaiting requested review from bgogul

@marcrasi marcrasi Awaiting requested review from marcrasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-zheng @rxwei @lattner