[AutoDiff upstream] Add @derivative(of:) attribute.
#28321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lattner
approved these changes
Nov 19, 2019
rxwei
added a commit
that referenced
this pull request
Nov 23, 2019
…utes. In the code review for #28321, the main developers of AutoDiff agreed to rename `@differentiating` and `@transposing` to `@derivative(of:)` and `@transpose(of:)`, respectively. This PR updates the manifesto to reflect this change.
dan-zheng
added a commit
to dan-zheng/swift
that referenced
this pull request
Nov 26, 2019
Rename `@differentiating` to `@derivative(of:)`. `@derivative(of:)` more clearly evokes derivative registration; the syntax is otherwise unchanged. Deprecate `@differentiating`, to be removed in the next release. Discussed here: swiftlang#28321 (comment) Partially resolves TF-999. TF-1000 tracks updating all `@differentiating` usages across repositories.
rxwei
pushed a commit
that referenced
this pull request
Nov 26, 2019
Rename `@differentiating` to `@derivative(of:)`. `@derivative(of:)` more clearly evokes derivative registration; the syntax is otherwise unchanged. Deprecate `@differentiating`, to be removed in the next release. Discussed here: #28321 (comment). Partially resolves TF-999. TF-1000 tracks updating all `@differentiating` usages across repositories. --- Confirmed via `grep -nr differentiating include lib stdlib test` that all remaining occurrences are intended. --- Example: ```swift extension Float { @Derivative(of: +) static func vjpAdd(lhs: Self, rhs: Self) -> (value: Self, pullback: (Self) -> (Self, Self)) { (lhs + rhs, { v in (v, v) }) } } ```
dan-zheng
added a commit
to dan-zheng/swift
that referenced
this pull request
Nov 26, 2019
Rename `@transposing` to `@transpose(of:)` and deprecate `@transposing`. `@transpose(of:)` more clearly evokes transpose registration; the syntax is otherwise unchanged. Discussed here: swiftlang#28321 (comment) Resolves TF-992. TF-999 tracks removing `@transposing` attribute in the next release. TF-1009 tracks `@transpose` syntax support for qualified names.
dan-zheng
added a commit
that referenced
this pull request
Nov 27, 2019
Rename `@transposing` to `@transpose(of:)`. `@transpose(of:)` more clearly evokes transpose registration; the syntax is otherwise unchanged. Discussed here: #28321 (comment) Remove `@transposing`. Removal without deprecation should be fine because there are no known users of `@transposing` attribute. Resolves TF-992. TF-1009 tracks `@transpose` syntax support for qualified names.
dan-zheng
force-pushed
the
upstream-differentiating-attr
branch
2 times, most recently
from
4b9f025 to
9acdfba
Compare
dan-zheng
changed the title
@differentiating attribute.@derivative(of:) attribute.
|
I addressed all comments and rebased onto master. There are no major changes: the biggest syntax change is renaming |
dan-zheng
added a commit
to dan-zheng/swift-syntax
that referenced
this pull request
Dec 10, 2019
…ibute. Update gyb-generated files for `@derivative` attribute. Friend PR: swiftlang/swift#28321
dan-zheng
added a commit
to dan-zheng/swift-syntax
that referenced
this pull request
Dec 10, 2019
Update gyb-generated files for `@derivative` attribute. Friend PR: swiftlang/swift#28321
dan-zheng
force-pushed
the
upstream-differentiating-attr
branch
from
9acdfba to
03ae118
Compare
The `@derivative(of:)` attribute registers a function as a derivative of another function. This patch adds the `@derivative(of:)` attribute definition, syntax, parsing, and printing. Resolves TF-826. Todos: - Type-checking (TF-829). - Serialization (TF-837).
dan-zheng
force-pushed
the
upstream-differentiating-attr
branch
from
03ae118 to
48e3b47
Compare
|
swiftlang/swift-syntax#188 |
|
Build failed |
|
Build failed |
|
Merging since there are no major changes since the last approval and CI has passed. |
dan-zheng
added a commit
that referenced
this pull request
Dec 10, 2019
Minor style fixes and gardening. Change code to be closer to master after #28321.
dan-zheng
added a commit
to dan-zheng/swift-syntax
that referenced
this pull request
Apr 8, 2020
Update gyb-generated files for `@derivative` attribute. Friend PR: swiftlang/swift#28321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@derivative(of:)attribute registers a function as a derivative of another function.This patch adds the
@derivative(of:)attribute definition, syntax, parsing, and printing.Resolves TF-826.
Todos: