[AutoDiff] Rename @transposing to @transpose(of:).
#28488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `@transposing` to `@transpose(of:)` and deprecate `@transposing`. `@transpose(of:)` more clearly evokes transpose registration; the syntax is otherwise unchanged. Discussed here: swiftlang#28321 (comment) Resolves TF-992. TF-999 tracks removing `@transposing` attribute in the next release. TF-1009 tracks `@transpose` syntax support for qualified names.
rxwei
approved these changes
Nov 26, 2019
|
@swift-ci Please test tensorflow |
Add deprecation tests for `@differentiating` and `@transposing`.
|
@swift-ci Please test tensorflow |
|
@bgogul gave the suggestion of deleting I think this makes sense, so I'll do it now. |
`@transposing` attribute has no known users, so deleting it outright makes maintenance easier. Other assorted gardening included.
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
@transposingto@transpose(of:).@transpose(of:)more clearlyevokes transpose registration; the syntax is otherwise unchanged.
Discussed here: #28321 (comment)
Remove
@transposing. Removal without deprecation should be fine becausethere are no known users of
@transposingattribute.Resolves TF-992.
TF-1009 tracks
@transposesyntax support for qualified names.