Fix some problems in ClangTypeConverter::getFunctionType #28726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Oops, this broke pointer equality as we create a duplicate function type. |
|
I think there are two options here: (a) @slavapestov's solution is suboptimal (I guess we don't check for equality there, so it only increases memory usage due to missed uniquing but doesn't affect correctness) or (b) this is a Clang bug where the |
|
@swift-ci please smoke test |
4 tasks
rjmccall
reviewed
Dec 12, 2019
|
The middle commit now makes sure that we add the @swift-ci please smoke test |
varungandhi-apple
deleted the
vg-fix-ClangTypeConverter.getFunctionType
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the fix for the thing pointed out in #28527.