-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Clang function types v2: Electric Boogaloo (parsing + printing) #28737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang function types v2: Electric Boogaloo (parsing + printing) #28737
Conversation
We should run still run the tests now though. @swift-ci please test |
Still haven't had the time to write the extra tests, will do that soon 😐. @swift-ci please test |
Tests are kinda' done. Seems minimal, but there's only so many things you can do with type declarations, I guess. When we return a function pointer through a typealias, then the type of the variable is |
@swift-ci please test |
Build failed |
Build failed |
@rjmccall LGTY? |
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
First three commits are from #28726.Tried to get it out soon for review. Some things are still TODO but the core things are done:Add some test cases for SIL printing. AST and SIL logic are very close, so this should be minimal work.We can't add test cases for this right now, because we aren't storing the type in SIL