[Serialization] Recover from a missing conforming type in a protocol conformance #29639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
Feb 4, 2020
lib/Serialization/DeserializeSIL.cpp
Outdated
Contributor
There was a problem hiding this comment.
could you add some comments why this error may happen? Otherwise LGTM.
Contributor
Author
There was a problem hiding this comment.
I've added documentation on the prototype for readWitnessTableChecked and on the only client readWitnessTables.
slavapestov
reviewed
Feb 4, 2020
Contributor
slavapestov
left a comment
slavapestov
left a comment
There was a problem hiding this comment.
This needs a test case.
xymus
force-pushed
the
recover-in-getAllWitnessTables
branch
2 times, most recently
from
8ab9dad to
05f34b1
Compare
Contributor
Author
|
@swift-ci Please smoke test |
xymus
force-pushed
the
recover-in-getAllWitnessTables
branch
from
05f34b1 to
9733627
Compare
Contributor
Author
|
@swift-ci Please smoke test |
…conformance We saw this failure with a Clang module imported @_implementationOnly with synthesized conformances by the ClangImporter. It caused issues only in sil-opt as it reads all the witness tables. rdar://problem/58924131
…ules The diagnostic function crashed as it did not take into account the DebuggerSupport options as the site reporting the missing dependency did. In this context, missing implementation-only imported dependencies are ignored only if DebuggerSupport is set.
xymus
force-pushed
the
recover-in-getAllWitnessTables
branch
from
9733627 to
6dc9dce
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw this failure with a Clang module imported @_implementationOnly with synthesized conformances by the ClangImporter. It caused issues only in sil-opt as it reads all the witness tables.
rdar://problem/58924131