[5.2][Serialization] Recover from a missing conforming type in a protocol conformance #30779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
…conformance We saw this failure with a Clang module imported @_implementationOnly with synthesized conformances by the ClangImporter. It caused issues only in sil-opt as it reads all the witness tables. rdar://problem/58924131 rdar://problem/61209195
…ules The diagnostic function crashed as it did not take into account the DebuggerSupport options as the site reporting the missing dependency did. In this context, missing implementation-only imported dependencies are ignored only if DebuggerSupport is set.
xymus
force-pushed
the
recover-in-getAllWitnessTables-5.2
branch
from
228f3e3 to
f4efec8
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
tkremenek
approved these changes
Apr 2, 2020
AnthonyLatsis
added
swift 5.2
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #29639.
Description: Non-compilation paths used by sil-opt try to read private declarations and fail on types declared behind implementation-only imports.
Scope: This should affect the sil-opt tool and might affect other non-compilation paths like the indexing phase.
Origin: A change in a framework made the compiler synthesized code for a C enum behind an implementation-only import.
Risk: Low, this fix only affects path that would otherwise have failed.
rdar://problem/61209195