Skip to content

[NFC][Python: black] Reformatted the benchmark Python sources using utils/python_format.py. #29719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

Rostepher
Copy link
Contributor

@Rostepher Rostepher commented Feb 8, 2020

Builds on the changes in #29718.

@Rostepher Rostepher requested review from gottesmm and edymtt February 8, 2020 07:24
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
DataAppendDataSmallToSmall 2760 3280 +18.8% 0.84x (?)
FlattenListLoop 2825 3252 +15.1% 0.87x (?)
FlattenListFlatMap 4904 5393 +10.0% 0.91x (?)

Code size: -O

Performance: -Osize

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@Rostepher Rostepher force-pushed the format-benchmark-scripts branch from b965e77 to b196174 Compare February 8, 2020 23:32
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2020

Build failed
Swift Test Linux Platform
Git Sha - b965e7705e912f37872b97480f39405097384d6e

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2020

Build failed
Swift Test OS X Platform
Git Sha - b965e7705e912f37872b97480f39405097384d6e

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2020

Performance: -O

Improvement OLD NEW DELTA RATIO
DropLastArray 5 4 -20.0% 1.25x (?)

Code size: -O

Performance: -Osize

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@Rostepher
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Feb 9, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
FlattenListLoop 2676 3185 +19.0% 0.84x (?)
DropFirstArray 13 14 +7.7% 0.93x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
DropFirstArray 13 14 +7.7% 0.93x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@Rostepher
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
FlattenListFlatMap 4194 6517 +55.4% 0.64x (?)
ObjectiveCBridgeStubToNSDate2 450 600 +33.3% 0.75x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b196174

@Rostepher
Copy link
Contributor Author

@swift-ci please clean test

@Rostepher Rostepher merged commit 9092b82 into swiftlang:master Feb 11, 2020
@Rostepher Rostepher deleted the format-benchmark-scripts branch February 11, 2020 10:29
@palimondo
Copy link
Contributor

palimondo commented Feb 16, 2020

I don’t think this was a very good idea. It has created completely unnecessary merge conflicts for me in pending PR #26462 and has significantly hurt the readability of source code in many places. Can we please revert this?
cc @eeckstein @gottesmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants