Skip to content

Revert "[NFC][Python: black] Reformatted the benchmark Python sources using utils/python_format.py." #30149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

palimondo
Copy link
Contributor

Reverts #29719

This is to enable landing of #26462 without mayor conflicts. Since #29719 appears to be a result of automatic source code transformation by a Black formatter, it could be re-done later, if still deemed beneficial. Personally I dislike the result quite a bit, but if that’s really the maintainer’s consensus, so be it…

@palimondo palimondo requested review from gottesmm and eeckstein March 1, 2020 15:15
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 1, 2020

Performance: -O

Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubToNSDate2 1050 980 -6.7% 1.07x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeStubNSDataAppend 1540 1660 +7.8% 0.93x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@gottesmm
Copy link
Contributor

gottesmm commented Mar 1, 2020

@palimondo please be sure when you are done landing your change here. Please reapply this!

@compnerd
Copy link
Member

This has conflicts, if this is still useful, please update it.

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@shahmishal shahmishal closed this Oct 5, 2020
@shahmishal shahmishal deleted the revert-29719-format-benchmark-scripts branch May 13, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants