SILOptimizer: Fix analysis invalidation after devirtualization. #30473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devirtualizing try_apply modified the CFG, but passes that run devirtualization were not invalidating any CFG analyses, such as the domtree. This could hypothetically have caused miscompilation, but will be caught by running with -sil-verify-all.
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@gottesmm I asked for your review, but please just rewrite it however you like rather than iterating on a PR that is just a simple bug fix. Note: it's very rare that I resort to returning unnamed tuples (std::pair). I almost always create a named struct, but it was expedient in this case. |
Contributor
Author
|
@gottesmm fyi, the bug is exposed by other commits that I was originally trying to batch together with this. -sil-verify-all does catch the problem. I haven't figured out how to reduce it to a separate unit test without those changes, but have a note to myself to try again if I get time. |
Contributor
|
@atrick ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devirtualizing try_apply modified the CFG, but passes that run
devirtualization were not invalidating any CFG analyses, such as the
domtree.
This could hypothetically have caused miscompilation, but will be
caught by running with -sil-verify-all.