Skip to content

Conversation

@atrick
Copy link
Contributor

@atrick atrick commented Mar 19, 2020

Reverts #30473

Sanity check because I didn't benchmark the original PR.

@atrick
Copy link
Contributor Author

atrick commented Mar 19, 2020

@swift-ci benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
DataAppendArray 3400 3100 -8.8% 1.10x (?)

Code size: -Osize

Performance: -Onone

Improvement OLD NEW DELTA RATIO
DataAppendDataSmallToSmall 3180 2800 -11.9% 1.14x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@atrick
Copy link
Contributor Author

atrick commented Mar 19, 2020

Definitely didn't cause any regressions

@atrick atrick closed this Mar 19, 2020
@slavapestov
Copy link
Contributor

Damn it.

@shahmishal shahmishal deleted the revert-30473-fix-devirtualizer-invalidate branch May 13, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants