CSGen: Infer generic arguments for explicit closure result types #33663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
force-pushed
the
unbound-closure-retty
branch
from
003ecc3 to
491cd51
Compare
xedin
requested changes
Aug 27, 2020
| closure->getExplicitResultTypeRepr(), | ||
| TypeResolverContext::InExpression, | ||
| // Introduce type variables for unbound generics. | ||
| OpenUnboundGenericType( |
There was a problem hiding this comment.
Could you please split this into two commits - first one to add OpenUnboundGenericType to the original code which is an actual functionality change here and second which does this resultTy refactoring?
AnthonyLatsis
force-pushed
the
unbound-closure-retty
branch
from
491cd51 to
61d86d5
Compare
xedin
approved these changes
Aug 27, 2020
|
@swift-ci please smoke test |
theroyakash
approved these changes
Aug 27, 2020
AnthonyLatsis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.