CSGen: Infer generic arguments in typed placeholders #33680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
xedin,
CodaFi and
slavapestov
and removed request for
xedin
xedin
approved these changes
Aug 30, 2020
|
@AnthonyLatsis Looks like you need to rebase manually... |
AnthonyLatsis
force-pushed
the
unbound-placeholder
branch
from
aa9767d to
bf13bfa
Compare
|
@swift-ci please smoke test |
Now that all sites have been refactored to pass a dedicated OpenUnboundGenericType callable, we can consistently move the construction of the opener into resolveTypeReferenceInExpression and have it take a ConstraintLocatorBuilder parameter instead
AnthonyLatsis
force-pushed
the
unbound-placeholder
branch
from
bf13bfa to
6b1b837
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be rebased on #33663, only the last 2 commits are relevant.