Revert "[cxx-interop] Support class templates containing typedefs." #34590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
CC: @zoecarver @hlopko |
compnerd
deleted the
revert-34557-cxx/fix/is-dependent-type-over-aligned
branch
Member
Author
|
@zoecarver that's a bug, @shahmishal might be able to identify why exactly it failed to trigger in the particular case. |
Member
|
This is known issue because windows is part of different infrastructure (Swift Community-Hosted CI vs Swift CI). |
Contributor
|
Good to know. In the future, I'll just do a smoke test and merge manually then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #34557
This seems to have caused a regression on Windows: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/3362/consoleText