[re-apply][cxx-interop] Support class templates containing typedefs. #34601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test. |
Contributor
Author
|
@swift-ci please smoke test OS X platform. |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test OS X platform. |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Nov 6, 2020
* 'main' of github.com:apple/swift: [re-apply][cxx-interop] Support class templates containing typedefs. (swiftlang#34601) [Concurrency] Add cancelAsyncTask() builtin. [SR-11711] Check active clause element is last expression. [NFC] Pull addAllDefinedDeclsOfAGivenType into its Base Class Statement setter for last element [SR-11711] Refactor shared parser code for single-expression returns [SR-11711] Single-expression returns for #if declarations within closures [SR-11711] Single-expression returns for #if declarations within functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an assertion in "isOverAligned" caused class templates that contain and use typedefs.
Re-landing 7f2b0aa after being reverted in 5ef0136.
Refs #34590 and #34557.