TODO: this is not required anymore. Remove it. + Zapping missing serializeAll parameter #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<code>allocaiton</code> -> <code>allocation</code>
Removing ShouldSerializeAll usage
|
/cc @gottesmm |
|
Please eliminate the merge commit. Please just rebase. I need to look at the rest of it still. |
|
Also, please make sure that this lands as a single commit, not 5 different commits. |
|
Can Fix Typo in Stack Promotion go into a different pull request? |
|
@gottesmm @gabrielPeart Pull requests should have one commit per issue, and contain exactly one distinct fix area. Mixing fixes to StackPromotion with the other stuff is not a good idea. |
|
You guys are right, I'm going to so a new pull request with a single commit and close this one. |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Fix install path
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Un-XFAIL SR-11135 and SR-11136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased + Tests pass