Fix TODO by removing unneeded ShouldSerializeAll parameters. #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alizeAll parameter
|
Did you run all of the tests? Also can you remove the TODO from the title of the commit and instead say something like this: Fix TODO by removing unneeded ShouldSerializeAll parameters. |
gabrielPeart
changed the title
|
Yes, I executed all tests and generated the build. Passed without problems. |
|
Sorry for being unclear, when I said the title of the commit, I meant the first line of the git commit msg. |
|
No problem. Looks okay now? |
|
The actual git commit looks the same to me. Are you sure you fixed it? |
|
I did amend in the commit message and sent a new pull request #420 |
gabrielPeart
added a commit
to gabrielPeart/swift
that referenced
this pull request
Dec 11, 2015
Pushing missing classes from the previous Pull Request
swiftix
added a commit
that referenced
this pull request
Dec 11, 2015
Adding missing changes on the Pull Request #402
swiftix
added a commit
that referenced
this pull request
Dec 11, 2015
swiftix
added a commit
that referenced
this pull request
Dec 11, 2015
Revert "Adding missing changes on the Pull Request #402"
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Linux i686 Build Support
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
…fails-for-recent-fixes [run_sk_stress_test] Update xfails after SR-11911 was fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TODO by removing unneeded ShouldSerializeAll parameters.
Closed old #357 and opening this new pull request
/cc @gottesmm