Driver: add support for the WebAssembly toolchain #39299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
changed the title
This comment has been minimized.
This comment has been minimized.
78 tasks
kateinoigakukun
requested changes
Sep 14, 2021
MaxDesiatov
force-pushed
the
maxd/driver-wasm-toolchain
branch
from
6bfc8a5 to
619ada3
Compare
This comment has been minimized.
This comment has been minimized.
MaxDesiatov
force-pushed
the
maxd/driver-wasm-toolchain
branch
from
619ada3 to
15d3da1
Compare
This comment has been minimized.
This comment has been minimized.
|
Could you add driver test for this toolchain using |
MaxDesiatov
force-pushed
the
maxd/driver-wasm-toolchain
branch
from
15d3da1 to
710816d
Compare
This comment has been minimized.
This comment has been minimized.
MaxDesiatov
force-pushed
the
maxd/driver-wasm-toolchain
branch
from
0663c41 to
8d224e6
Compare
This comment has been minimized.
This comment has been minimized.
MaxDesiatov
force-pushed
the
maxd/driver-wasm-toolchain
branch
from
8d224e6 to
db92ee4
Compare
This comment has been minimized.
This comment has been minimized.
MaxDesiatov
force-pushed
the
maxd/driver-wasm-toolchain
branch
from
db92ee4 to
d268f8d
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
MaxDesiatov
force-pushed
the
maxd/driver-wasm-toolchain
branch
from
c6c87be to
9e7c3c9
Compare
|
@swift-ci please smoke test |
kateinoigakukun
approved these changes
Oct 29, 2021
artemcm
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
The changes here look good to me. Sorry for the delay.
And thank you @MaxDesiatov!
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssemblyToolChains.cppis added to the Driver with a basic toolchain for WebAssembly. This supports building and linking Swift code that targets WebAssembly.Resolves a part of SR-9307.
CC @kateinoigakukun