[5.6] SIL optimizer: temporarily disable immortal arc elimination #41020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimizations based on deployment targets do not interfere well with inlinable functions rdar://87898692
Contributor
Author
|
@swift-ci test |
mikeash
approved these changes
Jan 26, 2022
Contributor
|
Build failed |
tbkka
approved these changes
Jan 26, 2022
Contributor
|
You should disable the optimization for serializable functions and leave it in place for others. |
Contributor
Author
|
@swift-ci test linux |
Contributor
Author
|
@swift-ci test |
Contributor
|
Note: a more accurate fix is being developed for the main branch in #41026. This quick fix is only for the 5.6 branch. |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizations based on deployment targets do not interfere well with inlinable functions
rdar://87898692