-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Disable deployment target specific optimizations for inlinable functions #41026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
We also need to fix availability guarded prespecialization uses. Something like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knitpick. Should we move this earlier in this function before the other checks.
aschwaighofer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
|
Build failed |
d38bb04 to
2f5aa9e
Compare
|
@swift-ci smoke test |
…resilience domain of the function.
2f5aa9e to
9016c2c
Compare
because they need a minimum deployment target, which might not be available in client modules, which de-serialize such functions.
|
@swift-ci smoke test |
The specified deployment target only applies to the currently compiled module, but not to any client modules, which use inlinable functions from the current module.
Therefore, optimizations which depend on the deployment target must not optimize inlinable functions, except they run after the module has been serialized.
rdar://88117184
The same thing needs to be done in Sema. There is already a PR for this: #33855, but unfortunately currently reverted.