Build support for ~Copyable atop @_moveOnly
#65556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We parse `~Copyable` in an inheritance clause of enum and struct decls as a synonym for the `@_moveOnly` attribute being added to that decl. This completely side-steps the additional infrastructure for generalized suppressed conformances in favor of a minimal solution. One benefit of this minimal solution is that it doesn't risk introducing any back-compat issues with older compilers or stdlibs. The trade-off is that we're more committed to supporting `@_moveOnly` in compiled modules in the future. In fact, this change does not deprecate `@_moveOnly` in any way. resolves rdar://106775103
kavon
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We parse
~Copyablein an inheritance clause of enum and struct decls as a synonym for the@_moveOnlyattribute being added to that decl. This completely side-steps the additional infrastructure for generalized suppressed conformances in favor of a minimal solution. One benefit of this minimal solution is that it doesn't risk introducing any back-compat issues with older compilers or stdlibs.The trade-off is that we're more committed to supporting
@_moveOnlyin compiled modules in the future. In fact, this change does not deprecate@_moveOnlyin any way.This is an alternate implementation of #64699
resolves rdar://106775103