[5.9 🍒] Build support for ~Copyable atop @_moveOnly
#65591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We parse `~Copyable` in an inheritance clause of enum and struct decls as a synonym for the `@_moveOnly` attribute being added to that decl. This completely side-steps the additional infrastructure for generalized suppressed conformances in favor of a minimal solution. One benefit of this minimal solution is that it doesn't risk introducing any back-compat issues with older compilers or stdlibs. The trade-off is that we're more committed to supporting `@_moveOnly` in compiled modules in the future. In fact, this change does not deprecate `@_moveOnly` in any way. resolves rdar://106775103
kavon
changed the title
~Copyable atop @_moveOnly~Copyable atop @_moveOnly
Member
Author
|
swiftlang/swift-syntax#1560 |
jckarter
approved these changes
May 2, 2023
tbkka
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: Allows people to write
~Copyablein the inheritance clause of an enum or struct to annotate that type as noncopyable. The approach in this PR is to internally annotate the type with@_moveOnly, so it side-steps any changes to the type system in favor of already-well-tested code paths that look for the attribuet.• Risk: Low. A
~appearing in the clause would never have parsed correctly before.Copyableis not even a valid type.• Original PR: #65556
• Reviewed By: Joe Groff
• Testing: regression tests included
• Resolves: rdar://106775103
Depends on companion PR for swift-syntax in 5.9: swiftlang/swift-syntax#1560