[Distributed] Support complex generic distributed actors in thunk gen #70842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-verifying-distributed-generics
branch
from
033d1ae to
7fc1ac4
Compare
ktoso
force-pushed
the
wip-verifying-distributed-generics
branch
from
6f77e86 to
20b1f6d
Compare
slavapestov
reviewed
Jan 11, 2024
ktoso
force-pushed
the
wip-verifying-distributed-generics
branch
from
a1c890c to
76c9e19
Compare
|
Okey finally managed to have this all correct -- thank you for the help @xedin @slavapestov ! |
|
@swift-ci please smoke test |
xedin
approved these changes
Jan 12, 2024
ktoso
changed the title
|
Heh, while this works locally on apple silicon it seems both linux and mac CI are not happy and we hit: Which seems like a null type -- probably the actor type; since yes we do not pass it a witness, perhaps that is the issue? Back to the investigation... |
ktoso
force-pushed
the
wip-verifying-distributed-generics
branch
3 times, most recently
from
5aa85cc to
8bcf07c
Compare
ktoso
commented
Jan 26, 2024
| /*decoderWitnessTable=*/void **), | ||
| /*actorType=*/Metadata *, | ||
| /*decoderWitnessTable=*/void **, | ||
| /*distributedActorWitnessTable=*/void ** |
There was a problem hiding this comment.
This mismatch was a lot of "fun" (not) to debug.
Thank you @xedin for the help debugging here 🙏
ktoso
force-pushed
the
wip-verifying-distributed-generics
branch
from
8bcf07c to
79005d5
Compare
|
@swift-ci please test |
|
macos had a git failure |
|
@swift-ci please test macOS |
ktoso
added
concurrency
|
@swift-ci please smoke test |
|
@swift-ci please test |
slavapestov
approved these changes
Jan 26, 2024
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
1 similar comment
|
@swift-ci please smoke test Windows |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally complete our adventure with generics and distributed thunks.
Description: Distributed thunks still incorrectly handled more complex generics cases, where the distributed func would use a generic type that had requirements on the enclosing actor type.
This corrects how distributed thunks use generics, i.e. we don't carry generic parameters over at all. A distributed thunk does not have to have the same generic signature as the target; all the types are fully substituted and the only generic parameters we need to carry over are the
InvocationDecoderand the actor type.Risk: Low, affects only more complex distributed actors with generics. The fix is well understood and tested.
Review by: @xedin @slavapestov
Testing: CI testing, added exact reproducer test for the complex scenarios.
Radar: rdar://115497090
Resolves: the final part of #68517