-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Distributed] Support complex generic distributed actors in thunk gen #70842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ktoso
merged 3 commits into
swiftlang:main
from
ktoso:wip-verifying-distributed-generics
Jan 28, 2024
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
test/Distributed/Runtime/distributed_actor_generic_constraint_issue_115497090.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // RUN: %empty-directory(%t) | ||
| // RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/../Inputs/FakeDistributedActorSystems.swift | ||
| // RUN: %target-build-swift -module-name main -Xfrontend -disable-availability-checking -j2 -parse-as-library -I %t %s %S/../Inputs/FakeDistributedActorSystems.swift -o %t/a.out | ||
| // RUN: %target-codesign %t/a.out | ||
| // RUN: %target-run %t/a.out | %FileCheck %s --color | ||
|
|
||
| // REQUIRES: executable_test | ||
| // REQUIRES: concurrency | ||
| // REQUIRES: distributed | ||
|
|
||
| // rdar://76038845 | ||
| // UNSUPPORTED: use_os_stdlib | ||
| // UNSUPPORTED: back_deployment_runtime | ||
|
|
||
| // FIXME(distributed): Distributed has some issues on windows currently, see also: rdar://82593574 | ||
| // UNSUPPORTED: OS=windows-msvc | ||
|
|
||
| import Distributed | ||
| import FakeDistributedActorSystems | ||
|
|
||
| protocol Key { | ||
| static var isInteger: Bool { get } | ||
| } | ||
|
|
||
| distributed actor TestActor<Object> where Object: Codable & Identifiable, Object.ID: Key { | ||
| public init(actorSystem: ActorSystem) { | ||
| self.actorSystem = actorSystem | ||
| } | ||
|
|
||
| public distributed func handleObject(_ object: Object) async throws { | ||
| print("self.id = \(object.id)") | ||
| } | ||
| } | ||
|
|
||
| struct SomeKey: Codable, Key, Hashable { | ||
| static var isInteger: Bool { false } | ||
| } | ||
|
|
||
| struct Something: Codable, Identifiable { | ||
| typealias ID = SomeKey | ||
| var id: SomeKey = .init() | ||
| } | ||
|
|
||
| typealias DefaultDistributedActorSystem = FakeRoundtripActorSystem | ||
|
|
||
| // ==== Execute ---------------------------------------------------------------- | ||
| @main struct Main { | ||
| static func main() async { | ||
| let system = DefaultDistributedActorSystem() | ||
|
|
||
| let actor: TestActor<Something> = TestActor(actorSystem: system) | ||
| let resolved: TestActor<Something> = try! .resolve(id: actor.id, using: system) | ||
| try! await resolved.handleObject(Something()) | ||
|
|
||
| // CHECK: self.id = SomeKey() | ||
|
|
||
| // CHECK: OK | ||
| print("OK") | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mismatch was a lot of "fun" (not) to debug.
Thank you @xedin for the help debugging here 🙏