ComputeSideEffects: correctly handle escaping arguments #73595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an argument escapes in a called function, we don't know anything about the argument's side effects. For example, it could escape to the return value and effects might occur in the caller. Fixes a miscompile swiftlang#73477 rdar://127691335
eeckstein
force-pushed
the
fix-compute-side-effects
branch
from
9783b02 to
4b2973a
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an argument escapes in a called function, we don't know anything about the argument's side effects. For example, it could escape to the return value and effects might occur in the caller.
Fixes a miscompile
#73477
rdar://127691335