Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] ComputeSideEffects: correctly handle escaping arguments #73610

Merged
merged 1 commit into from
May 14, 2024
Merged

[6.0] ComputeSideEffects: correctly handle escaping arguments #73610

merged 1 commit into from
May 14, 2024

Conversation

eeckstein
Copy link
Contributor

@eeckstein
ComputeSideEffects: correctly handle escaping arguments
618e8ee 
If an argument escapes in a called function, we don't know anything about the argument's side effects.
For example, it could escape to the return value and effects might occur in the caller.

Fixes a miscompile
swiftlang#73477
rdar://127691335
@eeckstein eeckstein requested a review from a team as a code owner May 14, 2024 05:56
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein eeckstein mentioned this pull request May 14, 2024
Closed
@eeckstein eeckstein merged commit a17d360 into swiftlang:release/6.0 May 14, 2024
5 checks passed
@eeckstein eeckstein deleted the fix-compute-side-effects-6.0 branch May 14, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeckstein @tbkka