AST/Sema: Model custom availability domains #79070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin and
artemcm
as code owners
|
@swift-ci please smoke test |
tshortli
force-pushed
the
model-custom-availability-domains
branch
from
358d55a to
76828ef
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
artemcm
approved these changes
Feb 1, 2025
| @@ -201,9 +201,42 @@ void AvailabilityInference::applyInferredAvailableAttrs( | |||
| Decl *ToDecl, ArrayRef<const Decl *> InferredFromDecls) { | |||
| auto &Context = ToDecl->getASTContext(); | |||
|
|
|||
| class OrderedAvailabilityDomain { | |||
There was a problem hiding this comment.
Could you please comment-clarify the kind of ordering and its purpose that this does?
Availability attribute inferrence is currently the only thing that depends on having a total ordering on AvailabilityDomains.
Store the domain definitions defined on the command line on the `ModuleDecl` for the main module.
tshortli
force-pushed
the
model-custom-availability-domains
branch
from
76828ef to
1e76f19
Compare
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/sourcekit-lsp
that referenced
this pull request
Feb 1, 2025
The diagnostic behavior it relied on is going away with swiftlang/swift#79070.
|
@swift-ci please smoke test |
SourceKit-LSP tests depend on the exact behavior of this diagnostic (which I don't plan to preserve) so I'm reverting the consolidation temporarily to get unblocked.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a "custom" availability domain kind and store the domain definitions defined on the command line on the
ModuleDeclas custom domains.