Parse/Sema: Consolidate diagnostics for unexpected versions #79098
+4
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin and
artemcm
as code owners
This was referenced Feb 1, 2025
Since resolving the domain of an `@available` attribute is done during type checking now, diagnostics about unexpected versions for a domain need to be emitted at that point instead of during parsing. It doesn't make sense to maintain the special version of this diagnostic that is emitted during parsing for the universal availability domain only.
tshortli
force-pushed
the
consolidate-unexpected-available-versions-diagnostic
branch
from
b79c33b to
427c8af
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since resolving the domain of an
@availableattribute is done during type checking now, diagnostics about unexpected versions for a domain need to be emitted at that point instead of during parsing. It doesn't make sense to maintain the special version of this diagnostic that is emitted during parsing for the universal availability domain only.Builds on #79070 and depends on swiftlang/sourcekit-lsp#1962.