Sema: Expand isolated conformance inference to consider conformances to inherited protocols #82383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
changed the title
slavapestov
force-pushed
the
implied-isolated-conformance
branch
from
d5ebf6c to
b1234b3
Compare
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
implied-isolated-conformance
branch
from
b1234b3 to
e5819c7
Compare
…to inherited protocols Otherwise, if PDerived inherits from P and P's requirements are witnessed by @MainActor-isolated members, we fail to infer @mainactor isolation on the conformance to PDerived. - Fixes swiftlang#82222. - Fixes rdar://153219831.
slavapestov
force-pushed
the
implied-isolated-conformance
branch
from
e5819c7 to
b0b23a0
Compare
|
@swift-ci Please smoke test |
DougGregor
reviewed
Jun 23, 2025
Comment on lines
+8160
to
+8161
| // Also check the value witnesses of each implied conformance to every | ||
| // inherited protocol, recursively. |
There was a problem hiding this comment.
Comment nit: this isn't checking the value witnesses specifically, it's considering the isolation of the inherited conformances.
Comment on lines
+8170
to
+8171
| if (isolation.isGlobalActor()) | ||
| return isolation; |
There was a problem hiding this comment.
When we infer isolation for from multiple sources elsewhere (for example, inferring type isolation from the protocols it conforms to), we refuse to infer isolation when there are conflicting inferences.. for example, @MainActor from one source and @SomeOtherGlobalActor from another source. Should we do the same here, rather than eagerly returning the first global actor isolation we find?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if PDerived inherits from P and P's requirements are witnessed by @MainActor-isolated members, we fail to infer @mainactor isolation on the conformance to PDerived.