[6.2] Sema: Expand isolated conformance inference to consider conformances to inherited protocols #82384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
implied-isolated-conformance-6.2
branch
2 times, most recently
from
bfffb9d to
66eee21
Compare
…to inherited protocols Otherwise, if PDerived inherits from P and P's requirements are witnessed by @MainActor-isolated members, we fail to infer @mainactor isolation on the conformance to PDerived. - Fixes swiftlang#82222. - Fixes rdar://153219831.
slavapestov
force-pushed
the
implied-isolated-conformance-6.2
branch
from
66eee21 to
f9a6432
Compare
|
@swift-ci Please test |
ricky-sharp
reviewed
Jun 24, 2025
| if (isa<TypeDecl>(requirement)) | ||
|
|
||
| // Also check the value witnesses of each implied conformance to every | ||
| // inherited protocol, recursively. |
There was a problem hiding this comment.
Didn't want this to get lost; see Doug Gregor's feedback on this code comment here: #82383 (comment)
ricky-sharp
reviewed
Jun 24, 2025
| auto isolation = assocConf->getIsolation(); | ||
| if (isolation.isGlobalActor()) | ||
| return isolation; | ||
| } |
There was a problem hiding this comment.
Also a question raised by Doug Gregor here regarding the above if: #82383 (comment)
DougGregor
approved these changes
Jun 25, 2025
|
We can handle my feedback in a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #82383
Description: This change expands isolated conformance inference to consider conformances to inherited protocols.
Otherwise, if PDerived inherits from P and P's requirements are witnessed by
@MainActor-isolated members, we fail to infer@MainActorisolation on the conformance to PDerived, forcing the user to write an explicit@MainActor.Scope of the issue: Usability problem with
-enable-upcoming-feature IsolatedConformanceInference.Issue: Fixes Default main actor isolation fails to deeply apply to some protocol hierarchies #82222.
Radar: Fixes rdar://153219831.
Risk: Medium, because it might introduce new request cycles, but only when this feature is enabled. This should be weighted against the usability improvement here.
Reviewed by: TBD